This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Review of --enable-gold=both patch

On 11/11/2010 01:08 AM, Matthias Klose wrote: 
+    if test x${default_ld} = xgold; then
+      AC_MSG_ERROR([either gold or ld can be the default ld])
+    fi

If you test for x${ENABLE_GOLD} = xdefault, the default_ld variable can go away.

+  no)
+    if test x${ENABLE_GOLD} != xyes; then
+      AC_MSG_ERROR([gold must be enabled to disable ld])
+    fi

I think this is not necessary, you can disable both packages. This would have the same effect as --without-gnu-ld. Please conditionalize the message on $use_gnu_ld != no and make it a warning rather than an error.

Ok with this fixed.

Paolo

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]