This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: C6x patch: Fix SPKERNEL assembly/disassembly
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Bernd Schmidt <bernds at codesourcery dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Wed, 6 Oct 2010 19:51:44 +0000 (UTC)
- Subject: Re: C6x patch: Fix SPKERNEL assembly/disassembly
- References: <4CACD0E0.9040809@codesourcery.com>
On Wed, 6 Oct 2010, Bernd Schmidt wrote:
> We don't handle the encoding of the SPKERNEL instruction correctly. The
> fstg field grows from the high bits, i.e. it is bit-reversed. The
> following patch corrects it in gas and objdump.
>
> I've verified the two new tests against the TI assembler/disassembler.
> Interestingly all the existing ones pass before and after the patch.
This is OK. The reason that the existing tests pass (I did verify
diassembly of all the positive tests with the TI disassembler when doing
the original port, as a sanity check for mistakes in the encodings listed
in the ISA manuals) is that what I was thinking of testing was the
boundary cases of largest/smallest field values accepted, meaning that all
those tests are of values with all fstg bits set, i.e. unaffected by the
reversal (and I didn't notice the table in the manual showing the
reversal).
--
Joseph S. Myers
joseph@codesourcery.com