This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 04/15] MIPS/GAS/test: Correct handling of arch overrides
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: "Maciej W. Rozycki" <macro at linux-mips dot org>
- Cc: binutils at sourceware dot org
- Date: Mon, 04 Oct 2010 21:35:01 +0100
- Subject: Re: [PATCH 04/15] MIPS/GAS/test: Correct handling of arch overrides
- References: <alpine.LFD.2.00.1010021952540.15889@eddie.linux-mips.org>
"Maciej W. Rozycki" <macro@linux-mips.org> writes:
> 2010-10-03 Maciej W. Rozycki <macro@linux-mips.org>
>
> gas/testsuite/
> * gas/mips/mips.exp (run_dump_test_arch): Get the name of the
> architecture to check against for an architecture-specific test
> from the properties instead of the name passed.
OK, although I'm uneasy about the way you're relying on an undocumented
implementation detail (the ordering of the properties). Please add a
comment like:
The first element is always the "canonical" target name for ARCH
after:
# mips_arch_properties ARCH (optional:) INCLUDE_GPRSIZE
#
# This function returns the property list associated with ARCH in the
# architecture data array. If INCLUDE_GPRSIZE is non-zero, an additional
# "gpr32" or "gpr64" property will be returned as part of the list based
# on the architecture's GPR size.
Richard