This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] libiberty: add HAVE_CONFIG_H check to all files (lacking it already)
On Tue, Aug 17, 2010 at 9:46 AM, Ian Lance Taylor wrote:
> Mike Frysinger writes:
>> On Tue, Aug 17, 2010 at 9:15 AM, Ian Lance Taylor wrote:
>>> No, those files were copied from projects like gnulib, which exist to
>>> provide files to be included in other programs.
>>
>> looking closer, i'm not sure that's true. ?there are plenty of files
>> labeled "This file is part of libiberty." that have HAVE_CONFIG_H
>> protection. ?what really strikes me though is that some files which
>> have this protection require other files which do not. ?which again is
>> how i got here in the first place.
>
> In that case I would personally prefer that the #ifdef HAVE_CONFIG_H be
> removed from those files, since it should not be needed.
well, that would cause me more issues, so i'm not inclined to post a
patch to "fix" those files ;)
guess i'll just live with having to modify files by hand in order to do testing
-mike