Re: [patch] Add --compress-debug-sections option to gas

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Mon, Jul 12, 2010 at 3:30 PM, Cary Coutant <ccoutant@google.com> wrote:
>> I think it should be mentioned on gas/NEWS. Also you should add
>> the new options to "as --help".
>
> How does this look?
>
> -cary
>
>
> ? ? ? ?* gas/NEWS: Add note about --compress-debug-sections.
> ? ? ? ?* gas/as.c (show_usage): Add --compress-debug-sections and
> ? ? ? ?--nocompress-debug-sections.
>
>
> diff --git a/gas/NEWS b/gas/NEWS
> index 1b7f9e9..db6b6d4 100644
> --- a/gas/NEWS
> +++ b/gas/NEWS
> @@ -9,6 +9,11 @@
>
> ?* Add support for the Renesas RX processor.
>
> +* New command line option, --compress-debug-sections, which requests
> + ?compression of DWARF debug information sections in the relocatable output
> + ?file. ?Compressed debug sections are supported by readelf, objdump, and
> + ?gold, but not currently by Gnu ld.
> +
> ?Changes in 2.20:
>
> ?* GNU/Linux targets now supports "gnu_unique_object" as a value in the .type
> diff --git a/gas/as.c b/gas/as.c
> index e494fa5..2457e8c 100644
> --- a/gas/as.c
> +++ b/gas/as.c
> @@ -246,6 +246,10 @@ Options:\n\
> ? fprintf (stream, _("\
> ? --alternate ? ? ? ? ? ? initially turn on alternate macro syntax\n"));
> ? fprintf (stream, _("\
> + ?--compress-debug-sections ?compress DWARF debug sections using zlib\n"));
> + ?fprintf (stream, _("\
> + ?--nocompress-debug-sections ?don't compress DWARF debug sections\n"));
> + ?fprintf (stream, _("\
> ? -D ? ? ? ? ? ? ? ? ? ? ?produce assembler debugging messages\n"));
> ? fprintf (stream, _("\
> ? --debug-prefix-map OLD=NEW ?Map OLD to NEW in debug information\n"));
>

It looks OK to me, except we should align the explanation text.  But I
can't approve it.

Thanks.


-- 
H.J.