This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
PR 11733
- From: Alan Modra <amodra at gmail dot com>
- To: binutils at sourceware dot org
- Date: Mon, 21 Jun 2010 17:22:01 +0930
- Subject: PR 11733
Committed.
PR gas/11733
* config/tc-sh.c (find_cooked_opcode): Correct array bounds check.
Index: gas/config/tc-sh.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-sh.c,v
retrieving revision 1.137
diff -u -p -r1.137 tc-sh.c
--- gas/config/tc-sh.c 25 May 2010 14:12:39 -0000 1.137
+++ gas/config/tc-sh.c 21 Jun 2010 07:21:44 -0000
@@ -2545,7 +2545,7 @@ find_cooked_opcode (char **str_p)
unsigned char *op_start;
unsigned char *op_end;
char name[20];
- int nlen = 0;
+ unsigned int nlen = 0;
/* Drop leading whitespace. */
while (*str == ' ')
@@ -2557,7 +2557,7 @@ find_cooked_opcode (char **str_p)
assemble_ppi, so the opcode might be terminated by an '@'. */
for (op_start = op_end = (unsigned char *) str;
*op_end
- && nlen < 20
+ && nlen < sizeof (name) - 1
&& !is_end_of_line[*op_end] && *op_end != ' ' && *op_end != '@';
op_end++)
{
--
Alan Modra
Australia Development Lab, IBM