This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch][gold] Add const to the add_input_file and add_input_library callbacks
- From: Ian Lance Taylor <iant at google dot com>
- To: Rafael Espindola <espindola at google dot com>
- Cc: Binutils <binutils at sourceware dot org>, Cary Coutant <ccoutant at google dot com>
- Date: Fri, 18 Jun 2010 08:43:58 -0700
- Subject: Re: [patch][gold] Add const to the add_input_file and add_input_library callbacks
- References: <AANLkTikiyzLVp0hzN47OsMomFFrwuiEbsYPN40DSCxGA@mail.gmail.com>
Rafael Espindola <espindola@google.com> writes:
> What is the correct procedure with plugin-api.h? Should I first commit
> it to the gcc repo and then copy it back?
Yes.
> gold/
> 2010-06-18 Rafael Espindola <espindola@google.com>
>
> * plugin.cc (add_input_file,add_input_library,
> Plugin_manager::add_input_file): Make filename arguments const.
> * plugin.h (Plugin_manager::add_input_file): Make filename arguments
> const.
>
>
> include/
> 2010-06-18 Rafael Espindola <espindola@google.com>
>
> * plugin.h (ld_plugin_add_input_file, ld_plugin_add_input_library):
> Make argument const.
This is OK here and in gcc. Send the include patch to gcc-patches and
note that I have already approved it.
Thanks.
Ian