This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [gold][patch] Fix two plugin bugs

From: Cary Coutant <ccoutant at google dot com>
To: Ian Lance Taylor <iant at google dot com>
Cc: Binutils <binutils at sourceware dot org>
Date: Thu, 10 Jun 2010 10:22:06 -0700
Subject: Re: [gold][patch] Fix two plugin bugs
References: <AANLkTimX74athOm607BI-oLoQitfNQXgONLzErVVRcHB@mail.gmail.com> <mcr4ohbtscw.fsf@dhcp-172-17-9-151.mtv.corp.google.com>

>> +two_file_test_1c.syms: two_file_test_1.syms two_file_test_1c.o
>> + ? ? cp two_file_test_1.syms $@
>> + ? ? grep "_Z4t16av" two_file_test_1b.syms >> $@
>
> Use a temporary file here rather than creating a possibly invalid
> target file; e.g., see many_sections_check.h.
>
> This is OK with that change.

OK, here's the patch as committed.

-cary

Attachment: gold-plugin-11683-patch.txt
Description: Text document

References:
- [gold][patch] Fix two plugin bugs
  - From: Cary Coutant
- Re: [gold][patch] Fix two plugin bugs
  - From: Ian Lance Taylor

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]