This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] fix shadowed variable i when DEBUG386 is on
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Quentin Neill <quentin dot neill dot gnu at gmail dot com>
- Cc: binutils at sourceware dot org
- Date: Mon, 7 Jun 2010 15:04:09 -0700
- Subject: Re: [PATCH] fix shadowed variable i when DEBUG386 is on
- References: <AANLkTiltJUmr8zNDdeNtJBjASFYXygSagFHYFKg65M0P@mail.gmail.com>
On Mon, Jun 7, 2010 at 2:56 PM, Quentin Neill
<quentin.neill.gnu@gmail.com> wrote:
> When building i386 assembler with -DDEBUG386 we get:
> config/tc-i386.c: In function 'pi':
> config/tc-i386.c:2344: error: declaration of 'i' shadows a global declaration
> config/tc-i386.c:365: error: shadowed declaration is here
>
> This fix renames it to j. ?Tested with "make check" on x86. ?Okay to commit?
>
> gas:
> ? ?* config/tc-i386.c (pi): Rename local loop counter
> ? ?variable i that shadows global static i386_insn i
> ? ?when DEBUG386 is defined.
> ? ?(pte) Ditto.
>
OK.
--
H.J.