This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH][ARM]: Fix unified syntax encoding of MOVS in Thumb.
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: Matthew Gretton-Dann <matthew dot gretton-dann at arm dot com>
- Cc: binutils at sourceware dot org
- Date: Fri, 28 May 2010 16:07:28 +0100
- Subject: Re: [PATCH][ARM]: Fix unified syntax encoding of MOVS in Thumb.
- References: <1274975966.14587.297.camel@e102319-lin.cambridge.arm.com>
On Thu, 2010-05-27 at 16:59 +0100, Matthew Gretton-Dann wrote:
> Hi,
>
> Can someone please review the attached patch?
>
> GAS currently encodes a Thumb-state MOVS as ADDS in unified syntax mode,
> which is incorrect - it should be encoded as LSLS. This patch corrects
> this.
>
> Thanks,
>
> Matt
>
> Proposed ChangeLogs:
>
> gas/ChangeLog:
> 2010-05-27 Matthew Gretton-Dann <matthew.gretton-dann@arm.com>
>
> * config/tc-arm.c (do_t_mov_cmp): In unified syntax encode movs
> as lsls and not adds.
>
> gas/testsuite/ChangeLog:
> 2010-05-27 Matthew Gretton-Dann <matthew.gretton-dann@arm.com>
>
> * gas/arm/thumb2_it_auto.d: Update for change in movs encoding.
> gas/arm/thumb2_it.d: Likewise.
> gas/arm/thumb32.d: Likewise.
>
OK.
Note, however, that the disassembler should be fixed to disassemble
these instructions as MOV(S).
R.