This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [RFA] Don't warn when using ld --wrap and code in Thumb-state on ARM
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Ian Lance Taylor <iant at google dot com>
- Cc: Matthew Gretton-Dann <matthew dot gretton-dann at arm dot com>, binutils at sourceware dot org
- Date: Tue, 6 Apr 2010 22:14:41 -0700
- Subject: Re: [RFA] Don't warn when using ld --wrap and code in Thumb-state on ARM
- References: <1269877707.25684.24.camel@e102111-lin.cambridge.arm.com> <20100329231213.GK6416@bubble.grove.modra.org> <mcrochwpby4.fsf@dhcp-172-17-9-151.mtv.corp.google.com>
On Tue, Apr 6, 2010 at 1:23 PM, Ian Lance Taylor <iant@google.com> wrote:
> Alan Modra <amodra@gmail.com> writes:
>
>> On Mon, Mar 29, 2010 at 04:48:27PM +0100, Matthew Gretton-Dann wrote:
>>> However, this change in symbol type is usually allowed for function
>>> symbols - _bfd_elf_merge_symbol indicates this. ?But in this case this
>>> hasn't been allowed because the test for both symbols being function
>>> type symbols is done after an early exit for weak symbols.
>>>
>>> The fix is to move the test for merging two function symbols, and so
>>> whether to allow a symbol type change earlier in _bfd_elf_merge_symbol.
>>
>> I'd rather see a fix to the check for weak versioned symbols. ?Ian
>> added that code here:
>> cvs diff -r 1.10 -r 1.11 elflink.h
>
> http://sourceware.org/ml/binutils/1999-q3/msg00042.html
>
> and follow-ups.
>
>
>> And made a fix here:
>> cvs diff -r 1.19 -r 1.20 elflink.h
>
> http://sourceware.org/ml/binutils/1999-q3/msg00254.html
>
> and follow-ups.
>
FWIW, their testcases may be:
http://sourceware.org/ml/binutils/1999-q3/msg00030.html
http://sourceware.org/ml/binutils/1999-q3/msg00031.html
They are related to weak symbol handling in older glibc.
Newer glibc treats weak symbols in DSO as strong symbols.
--
H.J.