This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Hi Ian, I made that change and submitted the patch. Thanks, -Sri. On Fri, Feb 19, 2010 at 8:50 PM, Ian Lance Taylor <iant@google.com> wrote: > Sriraman Tallam <tmsriram@google.com> writes: > >> 2010-02-19 ?Sriraman Tallam ?<tmsriram@google.com> >> >> ? ? ? * gc.h (gc_process_relocs): Change vectors to point to the new list. >> ? ? ? Add reloc offset information. >> ? ? ? * icf.cc (get_section_contents): Change iterators to point to the new >> ? ? ? vectors. Add reloc offset information to the contents. >> ? ? ? * icf.h (Icf::Sections_reachable_info): New typedef. >> ? ? ? (Icf::Sections_reachable_list): New typedef. >> ? ? ? (Icf::Offset_info): New typedef. >> ? ? ? (Icf::Reloc_info): New struct typedef. >> ? ? ? (Icf::Reloc_info_list): New typedef. >> ? ? ? (Icf::symbol_reloc_list): Delete method. >> ? ? ? (Icf::addend_reloc_list): Delete method. >> ? ? ? (Icf::section_reloc_list): Delete method. >> ? ? ? (Icf::reloc_info_list): New method. >> ? ? ? (Icf::reloc_info_list_): New member. > > >> + ? ? ? ? ? ? ?long long reloc_offset = static_cast<long long>( >> + ? ? ? ? ? ? ? ?convert_to_section_size_type(reloc.get_r_offset())); >> + ? ? ? ? ? (*offsetvec).push_back(reloc_offset); > > Don't use "long long". ?Use either section_size_type (note that you > are already converting to section_size_type) or use > elfcpp::Elf_types<size>::Elf_Addr. > >> + ? ? ? ? ? ? ?long long reloc_offset = static_cast<long long>( >> + ? ? ? ? ? ? ? ?convert_to_section_size_type(reloc.get_r_offset())); >> + ? ? ? ? ? (*offsetvec).push_back(reloc_offset); > > Here too. > >> + ?typedef std::vector<long long> Offset_info; > > Here use section_size_type or uint64_t. > > > This is OK with those changes. > > Thanks. > > Ian >
Attachment:
gold_icf_bug_patch.txt
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |