This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
readelf and SHT_GROUP flags
- From: Alan Modra <amodra at gmail dot com>
- To: binutils at sourceware dot org
- Date: Fri, 19 Feb 2010 12:06:07 +1030
- Subject: readelf and SHT_GROUP flags
A zero isn't exactly an unknown SHT_GROUP flag word, as that is what
is used for non-comdat groups.
* readelf.c (get_group_flags): Return empty string when flags zero.
Add space in other returned values.
(process_section_groups): Adjust format string.
Index: binutils/readelf.c
===================================================================
RCS file: /cvs/src/src/binutils/readelf.c,v
retrieving revision 1.484
diff -u -p -r1.484 readelf.c
--- binutils/readelf.c 9 Feb 2010 12:14:43 -0000 1.484
+++ binutils/readelf.c 18 Feb 2010 08:42:52 -0000
@@ -4633,11 +4633,14 @@ get_group_flags (unsigned int flags)
static char buff[32];
switch (flags)
{
+ case 0:
+ return "";
+
case GRP_COMDAT:
- return "COMDAT";
+ return "COMDAT ";
default:
- snprintf (buff, sizeof (buff), _("[<unknown>: 0x%x]"), flags);
+ snprintf (buff, sizeof (buff), _("[<unknown>: 0x%x] "), flags);
break;
}
return buff;
@@ -4797,7 +4800,7 @@ process_section_groups (FILE * file)
if (do_section_groups)
{
- printf ("\n%s group section [%5u] `%s' [%s] contains %u sections:\n",
+ printf ("\n%sgroup section [%5u] `%s' [%s] contains %u sections:\n",
get_group_flags (entry), i, name, group_name, size);
printf (_(" [Index] Name\n"));
--
Alan Modra
Australia Development Lab, IBM