This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH][GOLD] Add ARM relocation property table.
On Tue, 2010-02-02 at 20:40 -0800, Ian Lance Taylor wrote:
> "Doug Kwan (éæå)" <dougkwan@google.com> writes:
>
> > 2010-02-02 Doug Kwan <dougkwan@google.com>
> >
> > * Makefile.am (HFILES): Add arm-reloc-property.h.
> > (DEFFILES): New.
> > (TARGETSOURCES): Add arm-reloc-property.cc
> > (ALL_TARGETOBJS): Add arm-reloc-property.$(OBJEXT)
> > (libgold_a_SOURCES): $(DEFFILES)
> > * Makefile.in: Regenerate.
> > * arm-reloc-property.cc: New file.
> > * arm-reloc-property.h: New file.
> > * arm-reloc.def: New file.
> > * arm.cc: Update comments.
> > (arm-reloc-property.h): New included header.
> > (arm_reloc_property_table): New global variable.
> > (Target_arm::do_select_as_default_target): New method definition.
> > * configure.tgt (armeb*-*-*,armbe*-*-*,arm*-*-*): Add
> > arm-reloc-property to targ_extra_obj.
> > * parameters.cc (set_parameters_target): Call
> > Target::select_as_default_target().
> > * target.h (Target::select_as_default_target): New method definition.
> > (Target::do_select_as_default_target): Same.
>
>
> > + // strtok needs a non-const string pointer.
> > + char* buffer = new char[s.size() + 1];
Why +1? Presumably the size contains the null terminator.
> > + strcpy(buffer, s.c_str());
>
> Write memcpy(buffer, s.data(), s.size());
>
>
> This is OK with that change.
>
> Thanks.
>
> Ian