This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: seeing some -Wshadow warnings-turned-errors...

From: Nick Clifton <nickc at redhat dot com>
To: Joel Brobecker <brobecker at adacore dot com>
Cc: binutils at sourceware dot org
Date: Thu, 31 Dec 2009 11:46:53 +0000
Subject: Re: seeing some -Wshadow warnings-turned-errors...
References: <20091230095724.GB548@adacore.com>

Hi Joel,

So, I just want to confirm: Do we really want to fix those warnings?

Yes.

(huh? something's wrong with part of the patch, it says I'm replacing
basename, but it looks like I replace 'base' instead. double huh?)

Do you have an automatically created ChangeLog entry ? Maybe the scanner that does this is broken ?

            Fix -Wshadow warnings.
            * xcofflink.c: Replace finfo by flinfo throughout.
            (bfd_xcoff_split_import_path): Replace base by base_filename.

Approved - please apply.

Cheers
  Nick

References:
- seeing some -Wshadow warnings-turned-errors...
  - From: Joel Brobecker

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]