This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Fix build breakages on OSX due to -Wshadow and use of mempcpy.
HJ suggests me do thie fix differently for tc-i386.c. I wii check in
the part not related to tc-i386.c
-Doug
2009/12/14 Alan Modra <amodra@bigpond.net.au>:
> On Mon, Dec 14, 2009 at 12:11:33PM -0800, Doug Kwan (Ãö®¶¼w) wrote:
>> 2009-12-14 Doug Kwan <dougkwan@google.com>
>>
>> bfd/ChangeLog:
>>
>> * bfd-in2.h (bfd_opnr_iovec): Rename parameters to avoid shawdowed
>> declaration warnings.
>>
>> gas/ChangeLog:
>>
>> * config/tc-i386.c (show_arch): Replace uses of mempcpy with
>> equivalent code sequences with memcpy for portability.
>>
>> include/ChangeLog:
>>
>> * bfdlink.h (struct bfd_link_callbacks): Rename function parameters
>> to avoid shadowed declaration warnings.
>> * dis-asm.h (struct disassemble_info): Ditto.
>> (disassemble_init_for_target): Ditto.
>> (init_disassemble_info): Ditto.
>
> The patch is OK except that bfd-in2.h is a generated file. Apply your
> changes to opncls.c instead.
>
> --
> Alan Modra
> Australia Development Lab, IBM
>