This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Add XOP support for upcoming AMD Orochi processor
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Quentin Neill <quentin dot neill dot gnu at gmail dot com>
- Cc: binutils at sourceware dot org, Michael Matz <matz at suse dot de>, Jakub Jelinek <jakub at redhat dot com>, "Neill, Quentin" <quentin dot neill at amd dot com>, "Harle, Christophe" <christophe dot harle at amd dot com>, Sebastian Pop <sebpop at gmail dot com>
- Date: Thu, 10 Dec 2009 06:27:32 -0800
- Subject: Re: [PATCH] Add XOP support for upcoming AMD Orochi processor
- References: <cb9d34b20911171423l4e9b689bld2460d15d3d98cda@mail.gmail.com> <cb9d34b20911182016x155cfcd9h1a12e5f9b26c9dc3@mail.gmail.com> <6dc9ffc80911182123t5f816b9ax9134f6e057e4b880@mail.gmail.com> <cb9d34b20911202034k65ff3736i7507be89d0c59f51@mail.gmail.com> <1e2421410912092127t636b39bdi8204eb8857137038@mail.gmail.com>
On Wed, Dec 9, 2009 at 9:27 PM, Quentin Neill
<quentin.neill.gnu@gmail.com> wrote:
> Hi,
>
> We found another issue related to PR
> http://sourceware.org/bugzilla/show_bug.cgi?id=10973 when decoding
> operands with 4 byte displacements. ? The attached patch fixes this
> bug like this:
>
> ? ? ? ?gas/testsuite/
> ? ? ? ?* gas/testsuite/gas/i386/fma4.d: Add test cases.
> ? ? ? ?* gas/testsuite/gas/i386/fma4.s: Add test cases.
> ? ? ? ?* gas/testsuite/gas/i386/x86-64-fma4.d: Add test cases.
> ? ? ? ?* gas/testsuite/gas/i386/x86-64-fma4.s: Add test cases.
>
> ? ? ? ?opcodes/
> ? ? ? ?* opcodes/i386-dis.c (get_vex_imm8): Extend logic to
> ? ? ? ?apply in all cases, to avoid fetching ahead for the immediate
> ? ? ? ?bytes when OP_E_memory has already been called. ?Fix indentation.
>
> Tested with make -k check.
> Ok to commit?
>
> Thanks,
> --
OK.
--
H.J.