This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PR gas/10856
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: binutils at sourceware dot org
- Date: Sun, 6 Dec 2009 13:26:16 +1030
- Subject: Re: PR gas/10856
- References: <20091028082148.GD8111@bubble.grove.modra.org> <6dc9ffc80912042055g6918bfbcobfe4c66b8e2e5954@mail.gmail.com>
On Fri, Dec 04, 2009 at 08:55:26PM -0800, H.J. Lu wrote:
> On Wed, Oct 28, 2009 at 12:21 AM, Alan Modra <amodra@bigpond.net.au> wrote:
> > We already had a test for this PR. ?A pity the test expected a wrong
> > result.
> >
> > gas/
> > ? ? ? ?PR gas/10856
> > ? ? ? ?* expr.c (resolve_expression): Only add "left" value to O_symbol
> > ? ? ? ?expression when the symbol is undefined and different from the
> > ? ? ? ?original symbol. ?Simplify negative logic.
> > gas/testsuite/
> > ? ? ? ?* gas/i386/intelpic.d: Correct.
> >
>
> This patch caused:
>
> http://sourceware.org/bugzilla/show_bug.cgi?id=11037
Yes. I'm not sure yet what to do about it, but my initial look says
that the optimisation in resolve_expression for O_add is wrong to
simply set op to O_symbol and expect the later O_symbol code to do the
right thing.
--
Alan Modra
Australia Development Lab, IBM