This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][ARM] Handle --target1-abs, --target1-rel and --target2 options.


"Doug Kwan (éæå)" <dougkwan@google.com> writes:

> 2009-11-16  Doug Kwan  <dougkwan@google.com>
>
>         * arm.cc (Target_arm::Target_arm): Move method definition outside of
>         class definition.  Add code to handle --target1-rel, --target1-abs
>         and --target2= options.
>         (Target_arm::get_reloc_reloc_type): Change method to be non-static
>         and const.
>         (Target_arm::target1_is_rel_, Target_arm::target2_reloc_): New data
>         member declaration.
>         (Target_arm::Scan::local, Target_arm::Scan::global,
>         Target_arm::Relocate::relocate,
>         Target_arm::Relocatable_size_for_reloc::get_size_for_reloc): Adjust
>         call to Target_arm::get_real_reloc_type.
>         (Target_arm::get_real_reloc_type): Use command line options to
>         determine real types of R_ARM_TARGET1 and R_ARM_TARGET2.
>         * options.h (--target1-rel, --target1-abs, --target2): New ARM-only
>         options.


> +  if (parameters->options().user_set_target1_abs()
> +      && parameters->options().user_set_target1_rel())
> +    {
> +      gold_error(N_("Cannot use both --target1-abs and --target1-rel."));
> +    }

In code, use _(, not N_(.

This is OK with that change.

Thanks.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]