This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [GAS] [PATCH] Added support for the ARM VMSR and VMRS instructions
- From: Nick Clifton <nickc at redhat dot com>
- To: Viktor Kutuzov <vkutuzov at accesssoftek dot com>
- Cc: binutils at sourceware dot org
- Date: Thu, 12 Nov 2009 10:03:22 +0000
- Subject: Re: [GAS] [PATCH] Added support for the ARM VMSR and VMRS instructions
- References: <6AE1604EE3EC5F4296C096518C6B77EEE56FBF79@mail.accesssoftek.com> <6AE1604EE3EC5F4296C096518C6B77EEE56FBF7F@mail.accesssoftek.com> <6AE1604EE3EC5F4296C096518C6B77EEED7DBE12@mail.accesssoftek.com> <6AE1604EE3EC5F4296C096518C6B77EEED7DBE18@mail.accesssoftek.com> <9F13EC38E09E4F399942EDFD2A31268B@andreic6e7fe55>
Hi Viktor,
Attached is a patch that adds a support for the ARM VMSR and VMRS
instructions.
The patch is mostly OK, but there are a few issues:
--- gas/config/tc-arm.c 3 Nov 2009 12:37:44 -0000 1.413
+++ gas/config/tc-arm.c 11 Nov 2009 02:22:49 -0000
@@ -6303,6 +6395,7 @@
if (found != 15)
goto failure;
inst.operands[i].isvec = 1;
+ inst.operands[i].reg = 15;
}
else
goto failure;
What is the purpose of this change ?
+ /* APSR_ sets isvec. All other refs to PC are illegal */
Comment formatting. Should end: illegal. */
One other point. Please could you add a couple of lines to
gas/testsuite/gas/arm/vfp1xD.s and vfp1xD.d to check the assembly of the
vmsr and vmrs instructions ?
Cheers
Nick