Re: PATCH: PR ld/10630: Linker generates hidden local symbols

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Mon, Sep 14, 2009 at 12:04 AM, Alan Modra <amodra@bigpond.net.au> wrote:
> On Sat, Sep 12, 2009 at 06:43:01AM -0700, H.J. Lu wrote:
>> On Sat, Sep 12, 2009 at 5:42 AM, Alan Modra<amodra@bigpond.net.au> wrote:
>> > On Fri, Sep 11, 2009 at 12:50:12PM -0700, H.J. Lu wrote:
>> >> This patch turns off visibility on local symbol and dynamic local symbol.
>> >> Tested on Linux/ia32, Linux/ia64 and Linux/x86-64 as well as for
>> >> alpha-linux, cris-elf, s390-linux, sparc-linux, powerpc-linux and
>> >> xtensa-linux with cross binutils. ?There are no regressions. ?OK
>> >> to install?
>> >
>> > Does having non-default visibility on a local symbol break some
>> > application?
>>
>> It failed a test in elfutils on ia64 due to hidden dynamic local symbol,
>> which leads to rpm build failure.
>
> I'm not willing to OK your patch on the strength of a failed elfutils
> test. ?That's not to say I'm against the patch, just that I'm unsure
> what the ELF gabi intends. ?I won't be unhappy if someone else wants
> to OK it..
>
> The ELF gabi says "A symbol with STB_LOCAL binding may not have
> STV_PROTECTED visibility." ?It does not say anything like this about
> STV_HIDDEN or STV_INTERNAL. ?That leads me to think that STB_LOCAL
> symbols may be marked STV_HIDDEN or STV_INTERNAL. ?(Such symbols
> wouldn't be inconsistent with the definitions of STB_LOCAL or
> STV_HIDDEN/STV_INTERNAL.)
>
> However, it does seem quite useless to have anything other than
> STV_DEFAULT local symbols, but maybe my imagination isn't good
> enough.
>

This patch adds a test for local STV_PROTECTED symbols. OK to
install?

Thanks.

-- 
H.J.
---
bfd/

2009-09-23  H.J. Lu  <hongjiu.lu@intel.com>

	PR ld/10630
	* elflink.c (elf_link_output_extsym): Turn off visibility on
	local symbol.
	(bfd_elf_final_link): Turn off visibility on dynamic local
	symbol.

ld/testsuite/

2009-09-23  H.J. Lu  <hongjiu.lu@intel.com>

	PR ld/10630
	* ld-alpha/tlsbin.rd: Remove HIDDEN/.hidden on local symbols.
	* ld-alpha/tlsbinr.rd: Likewise.
	* ld-alpha/tlspic.rd: Likewise.
	* ld-cris/libdso-2.d: Likewise.
	* ld-cris/locref1.d: Likewise.
	* ld-cris/locref2.d: Likewise.
	* ld-cris/tls-e-20a.d: Likewise.
	* ld-cris/tls-e-20.d: Likewise.
	* ld-cris/tls-e-80.d: Likewise.
	* ld-cris/tls-gc-68.d: Likewise.
	* ld-cris/tls-gc-69.d: Likewise.
	* ld-cris/tls-gc-70.d: Likewise.
	* ld-cris/tls-gc-75.d: Likewise.
	* ld-cris/tls-gc-76.d: Likewise.
	* ld-cris/tls-gc-79.d: Likewise.
	* ld-cris/tls-gd-1h.d: Likewise.
	* ld-cris/tls-gd-2h.d: Likewise.
	* ld-cris/tls-ld-4.d: Likewise.
	* ld-cris/tls-ld-5.d: Likewise.
	* ld-cris/tls-ld-6.d: Likewise.
	* ld-cris/tls-ld-7.d: Likewise.
	* ld-cris/tls-ldgd-14.d: Likewise.
	* ld-cris/tls-ldgd-15.d: Likewise.
	* ld-cris/tls-local-63.d: Likewise.
	* ld-cris/tls-local-64.d: Likewise.
	* ld-elf/pr9676.rd: Likewise.
	* ld-elf/pr9679.rd: Likewise.
	* ld-elfvsb/hidden2.d: Likewise.
	* ld-i386/tlsbindesc.rd: Likewise.
	* ld-i386/tlsbin.rd: Likewise.
	* ld-i386/tlsdesc.rd: Likewise.
	* ld-i386/tlsgdesc.rd: Likewise.
	* ld-i386/tlsnopic.rd: Likewise.
	* ld-i386/tlspic.rd: Likewise.
	* ld-ia64/tlsbin.rd: Likewise.
	* ld-ia64/tlspic.rd: Likewise.
	* ld-powerpc/tlsexe32.r: Likewise.
	* ld-powerpc/tlsexe.r: Likewise.
	* ld-powerpc/tlsexetoc.r: Likewise.
	* ld-powerpc/tlsso32.r: Likewise.
	* ld-powerpc/tlsso.r: Likewise.
	* ld-powerpc/tlstocso.r: Likewise.
	* ld-s390/tlsbin_64.rd: Likewise.
	* ld-s390/tlsbin.rd: Likewise.
	* ld-s390/tlspic_64.rd: Likewise.
	* ld-s390/tlspic.rd: Likewise.
	* ld-sparc/gotop32.rd: Likewise.
	* ld-sparc/gotop64.rd: Likewise.
	* ld-sparc/tlssunbin32.rd: Likewise.
	* ld-sparc/tlssunbin64.rd: Likewise.
	* ld-sparc/tlssunnopic32.rd: Likewise.
	* ld-sparc/tlssunnopic64.rd: Likewise.
	* ld-sparc/tlssunpic32.rd: Likewise.
	* ld-sparc/tlssunpic64.rd: Likewise.
	* ld-x86-64/tlsbindesc.rd: Likewise.
	* ld-x86-64/tlsbin.rd: Likewise.
	* ld-x86-64/tlsdesc.rd: Likewise.
	* ld-x86-64/tlsgdesc.rd: Likewise.
	* ld-x86-64/tlspic.rd: Likewise.
	* ld-xtensa/tlsbin.rd: Likewise.
	* ld-xtensa/tlspic.rd: Likewise.

	* ld-elf/local1.d: New.
	* ld-elf/local1.map: Likewise.
	* ld-elf/local1.s: Likewise.
	* ld-ia64/local1.d: Likewise.
	* ld-ia64/local1.map: Likewise.
	* ld-ia64/local1.s: Likewise.

Attachment: binutils-local-3.patch
Description: Text document