This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
testsuite readelf output
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: binutils at sourceware dot org
- Date: Wed, 23 Sep 2009 13:10:36 +0930
- Subject: testsuite readelf output
I've just committed a patch that relaxes certain whitespace matching
on readelf output throughout our binutils testsuite. It's boring and
large so I won't post it here.
The aim was to make the following patch possible.
* readelf.c (print_dynamic_symbol): Format entries as for
normal symbol table.
(process_symbol_table): Use -7s format string for visibility.
Does anyone strongly object to this being applied mainline? I chose a
width of seven for visibility as that suits "DEFAULT", and makes
"HIDDEN" symbol names line up with default symbols. "PROTECTED" and
"INTERNAL" of course still result in ragged columns.
Index: binutils/readelf.c
===================================================================
RCS file: /cvs/src/src/binutils/readelf.c,v
retrieving revision 1.460
diff -u -p -r1.460 readelf.c
--- binutils/readelf.c 21 Sep 2009 11:51:01 -0000 1.460
+++ binutils/readelf.c 23 Sep 2009 03:20:51 -0000
@@ -7226,9 +7226,9 @@ print_dynamic_symbol (bfd_vma si, unsign
putchar (' ');
print_vma (psym->st_size, DEC_5);
- printf (" %6s", get_symbol_type (ELF_ST_TYPE (psym->st_info)));
- printf (" %6s", get_symbol_binding (ELF_ST_BIND (psym->st_info)));
- printf (" %3s", get_symbol_visibility (ELF_ST_VISIBILITY (psym->st_other)));
+ printf (" %-7s", get_symbol_type (ELF_ST_TYPE (psym->st_info)));
+ printf (" %-6s", get_symbol_binding (ELF_ST_BIND (psym->st_info)));
+ printf (" %-7s", get_symbol_visibility (ELF_ST_VISIBILITY (psym->st_other)));
/* Check to see if any other bits in the st_other field are set.
Note - displaying this information disrupts the layout of the
table being generated, but for the moment this case is very
@@ -7532,7 +7532,7 @@ process_symbol_table (FILE * file)
print_vma (psym->st_size, DEC_5);
printf (" %-7s", get_symbol_type (ELF_ST_TYPE (psym->st_info)));
printf (" %-6s", get_symbol_binding (ELF_ST_BIND (psym->st_info)));
- printf (" %-3s", get_symbol_visibility (ELF_ST_VISIBILITY (psym->st_other)));
+ printf (" %-7s", get_symbol_visibility (ELF_ST_VISIBILITY (psym->st_other)));
/* Check to see if any other bits in the st_other field are set.
Note - displaying this information disrupts the layout of the
table being generated, but for the moment this case is very rare. */
--
Alan Modra
Australia Development Lab, IBM