Re: Patch to remove the use of the c++ keyword class in binutil sources.

[Dave Korn <dave dot korn dot cygwin at googlemail dot com>]

Martin Thuresson wrote:
> On Fri, Aug 28, 2009 at 1:23 PM, Dave
> Korn<dave.korn.cygwin@googlemail.com> wrote:
>> Martin Thuresson wrote:
>>> Found a small issue with new.patch. Updated the patch again.
>>>
>>> I also included a patch that renames all uses of the word template to
>>> avoid clashes with the C++ keyword.
>>  Sorry for the delay in getting to this.  I can only approve the COFF parts,
>> but I'll try to at least review the whole thing for you sometime tomorrow;
>> thanks for doing this work, and be assured you haven't gone un-noticed!
>>
>>  Do you have a GNU copyright assignment on record?  I'm not 100% certain, but
>> I think the scale of the patch might require one, even though it's basically a
>> mechanical job.
> 
> Thanks for following up. Im told that I am covered by googles copyright
> assignment (martint@).

  In fact, Nick got to it first and checked it in before me (Thanks Nick!),
but while I was looking into it I found this bit from the GNU maintainer's info:

http://www.gnu.org/prep/maintain/maintain.html#Legally-Significant

> A regular series of repeated changes, such as renaming a symbol, is not
> legally significant even if the symbol has to be renamed in many places.

  So I think a mechanical patch is OK anyway, but being under Google's assign
certainly eliminates any doubt.  Thanks for your contribution :)

    cheers,
      DaveK