Re: PATCH: PR gas/10531: Strange assembler warning message on section group

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Tue, Aug 18, 2009 at 10:52 AM, Daniel Jacobowitz<drow@false.org> wrote:
> On Tue, Aug 18, 2009 at 10:19:25AM -0700, H.J. Lu wrote:
>> Well, there is only a string to identify a section. For ELF, we also
>> need to check the group name. Do you have a better name for
>> the new function?
>
> Then either fix that (non-string way to represent the section), or
> better explain what you actually need. ?Do you need "the section named
> .stab that is not in any group"? ?Maybe that could be called the
> 'default section' for a given name.
>

Here is an updated patch to avoid compare segment name in
subseg_get.

Thanks.


-- 
H.J.
bfd/

2009-08-18  H.J. Lu  <hongjiu.lu@intel.com>

	 PR gas/10531
	 * section.c: Include "elf-bfd.h".
	 (bfd_get_section_by_name): Don't use a section in a section
	 group.
	 (bfd_make_section_old_way): Likewise.

gas/

2009-08-18  H.J. Lu  <hongjiu.lu@intel.com>

	 PR gas/10531
	 * subsegs.c (subseg_get): Don't compare segment name.

gas/testsuite/

2009-08-18  H.J. Lu  <hongjiu.lu@intel.com>

	 PR gas/10531
	 * gas/elf/group2.d: New.
	 * gas/elf/group2.s: Likewise.
	 * gas/i386/debug1.d: Likewise.
	 * gas/i386/debug1.s: Likewise.

	* gas/elf/elf.exp: Run group2.

	* gas/i386/i386.exp: Run debug1 for both 32bit and 64bit.

Attachment: binutils-group-2.patch
Description: Text document