This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [hppa] Fix disassembly of bb condition codes
- From: Nick Hudson <nick dot hudson at gmx dot co dot uk>
- To: binutils at sourceware dot org
- Cc: "John David Anglin" <dave at hiauly1 dot hia dot nrc dot ca>, randolph at tausq dot org
- Date: Fri, 14 Aug 2009 08:42:42 +0100
- Subject: Re: [hppa] Fix disassembly of bb condition codes
- References: <200603042215.k24MF5jq023181@hiauly1.hia.nrc.ca>
On Saturday 04 March 2006 22:15:05 John David Anglin wrote:
> > > Currently binutils doesn't properly differentiate between 32-bit and
> > > 64-bit condition codes for the hppa bb insn, always disassembling the
> > > condition code as a 64-bit condition if it is in pa20 mode. This patch
> > > fixes the problem.
> >
> > I don't believe the change is correct. 'B' is for 64-bit conditions.
> > This affects the printed bit position. So, printing a 32-bit code with
> > a 64-bit position would be wrong.
>
> I've committed the following change. Tested on hppa-unknown-linux-gnu
> and by visually inspecting the disassembly of some bb instructions.
> Let me know if you see any problems.
This breaks, e.g.
sign: .equ 8
bb sign, 0, foo
as FLAG_STRICT is now set on all entries. Not sure what the fix is
Nick