This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Support Xilinx MicroBlaze processor - patch 2
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Michael Eager <eager at eagercon dot com>
- Cc: binutils <binutils at sourceware dot org>
- Date: Fri, 31 Jul 2009 17:38:46 +0000 (UTC)
- Subject: Re: Support Xilinx MicroBlaze processor - patch 2
- References: <4A73150E.8070103@eagercon.com>
There seem to be various GNU Coding Standards violations in this code.
Functions in microblaze-dis.c seem generally to be missing comment them,
and there are lots of function calls without a space between the function
name and opening parenthesis. Code formatting such as
+ if (inst == 0) {
+ return -1;
+ }
does not follow the standards for placing "{" either. This patch also has
C++ comments.
--
Joseph S. Myers
joseph@codesourcery.com