Re: PATCH: PR ld/10433: Latest ld fails to link ldconfig properly

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Wed, Jul 22, 2009 at 5:41 PM, David Daney<ddaney@caviumnetworks.com> wrote:
> H.J. Lu wrote:
>>
>> On Wed, Jul 22, 2009 at 4:34 PM, Alan Modra<amodra@bigpond.net.au> wrote:
>>>
>>> On Wed, Jul 22, 2009 at 02:32:27PM -0700, H.J. Lu wrote:
>>>>
>>>> Hi,
>>>>
>>>> A STT_GNU_IFUNC symbol goes through PLT only if it is ever referenced.
>>>> I checked in this patch to fix it.
>>>
>>> You don't have global authority to commit patches. ?I'd normally let
>>> this sort of patch pass, but I quite clearly explained why I removed
>>> your test of ref_regular before. ?Please revert this patch and instead
>>> fix it in your target finish_dynamic_symbol.
>>>
>>
>> I disagree. If ref_regular isn't set properly, IFUNC may not work
>> properly at all. I will revert my patch and move it to the Linux
>> binutils instead.
>
> Granted all GNU/Linux systems use your binutils fork, but
> could you explain why the issue is important enough to fix in your binutils
> fork, but doesn't merit fixing in the sourceware.org version?
>

There is a disagreement on what the correct fix is. Anyone can apply
my fix on he GNU binutils if they want IFUNC symbols to work
properly in static executables.

-- 
H.J.