[committed] Re: Results for 2.19.51.20090622 testsuite on i686-pc-cygwin

[Dave Korn <dave dot korn dot cygwin at googlemail dot com>]

Christian Joensson wrote:

> Running target unix
> FAIL: cdtest with -Ur
> ERROR: tcl error sourcing
> /usr/local/src/trunk/src/ld/testsuite/ld-pe/pe-run.exp.
> ERROR: wrong # args: should be "ld_simple_link ld target objects"

  <kicks self>  Sigh, I guess the lesson I should learn is "Don't ever even
think you can get away with making whitespace changes between your last test
and committing the code".  >wanders off swearing under his breath about how
rubbish tcl is<

ld/testsuite/ChangeLog:

	* ld-pe/pe-run.exp (proc test_direct_link_dll):  Fix incorrect
	line-wrapping.

  Committed.  I also ate some worms as penitence for messing up.  Thanks for
the heads-up, Christian.

    cheers,
      DaveK

Index: ld-pe/pe-run.exp
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-pe/pe-run.exp,v
retrieving revision 1.2
diff -p -u -r1.2 pe-run.exp
--- ld-pe/pe-run.exp	18 Jun 2009 02:47:51 -0000	1.2
+++ ld-pe/pe-run.exp	22 Jun 2009 09:33:49 -0000
@@ -83,7 +83,7 @@ proc test_direct_link_dll {} {
 	} else {
 	    # Check linking directly to direct_dll.dll.
 	    set msg "linking client (.dll)"
-	    if [ld_simple_link "$CC -Wl,--enable-auto-import" $tmpdir/direct_client_dll.exe
+	    if [ld_simple_link "$CC -Wl,--enable-auto-import" $tmpdir/direct_client_dll.exe \
 	      "$tmpdir/direct_client.o $tmpdir/direct_dll.dll" ] {
 		pass $msg
 	    } else {
@@ -92,7 +92,7 @@ proc test_direct_link_dll {} {
 
 	    # Check linking directly to direct_dll.sl.
 	    set msg "linking client (.sl)"
-	    if [ld_simple_link "$CC -Wl,--enable-auto-import" $tmpdir/direct_client_sl.exe
+	    if [ld_simple_link "$CC -Wl,--enable-auto-import" $tmpdir/direct_client_sl.exe \
 	      "$tmpdir/direct_client.o $tmpdir/direct_dll.sl" ] {
 		pass $msg
 	    } else {
@@ -103,7 +103,7 @@ proc test_direct_link_dll {} {
 	    # Create symbolic link.
 	    catch "exec ln -fs direct_dll.dll $tmpdir/libdirect_dll.dll.a" ln_catch
 	    set msg "linking client (symlink -> .dll)"
-	    if [ld_simple_link "$CC -Wl,--enable-auto-import" $tmpdir/direct_client_symlink_dll.exe
+	    if [ld_simple_link "$CC -Wl,--enable-auto-import" $tmpdir/direct_client_symlink_dll.exe \
 	      "$tmpdir/direct_client.o $tmpdir/libdirect_dll.dll.a" ] {
 	        pass $msg
 	    } else {
@@ -114,7 +114,7 @@ proc test_direct_link_dll {} {
 	    # Create symbolic link.
 	    catch "exec ln -fs direct_dll.sl $tmpdir/libdirect_sl.dll.a" ln_catch
 	    set msg "linking client (symlink -> .sl)"
-	    if [ld_simple_link "$CC -Wl,--enable-auto-import" $tmpdir/direct_client_symlink_sl.exe
+	    if [ld_simple_link "$CC -Wl,--enable-auto-import" $tmpdir/direct_client_symlink_sl.exe \
 	      "$tmpdir/direct_client.o $tmpdir/libdirect_sl.dll.a" ] {
 		pass $msg
 	    } else {