This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: support for NEC SX architecture


hi, nick, dave!

first of all, thanks for the review; appreciate the comments (and
eagerly awaiting yours, dave).

On Thu, 2009-06-18 at 07:51 +0100, Nick Clifton wrote:
>    * You do not appear to have an FSF binutils copyright assignment.
>      Without such an assignment we cannot accept your contribution.
>      I have attached a form for you to fill out and email off in order
>      to start this application process rolling.
sure: I expect erich to have the final say in the copyright assignment
issues, so he'll comment on this.

>    * The new files are licensed under version 2 of the GPL.
>      The binutils sources are now being distributed under version 3
>      of the GPL.  Do you have any objections to changing the license
>      on your contributed files to GPLv3 ?
not me. once again, it's erich's call.

>      I suspect some of the problems are due to the fact that the test
>      harnesses are assuming that a Linux targeted port is also an ELF
>      based port.  Are you really running a COFF based linux using this
>      toolchain ?
well, the linux toolchain is a bit experimental and not really ready for
public consumption yet (there is also no publicly available kernel yet),
so perhaps it would be best to leave it out of the upstream patch - I
can maintain it in a private tree easily.

(it really is used to build a variant of a radically trimmed down linux
kernel, https://software.sandia.gov/trac/kitten , which we are currently
porting to SX and is intended for use in computational clusters, not
unlike CNL. and yes, our port really is a COFF based kernel as we dont
have an ELF bootloader yet. anyway, it is expected that it will be
obsoleted by a future ELF toolchain for Linux on SX.)

> If these problems can be resolved then I will be happy to accept your 
> contribution.
sure. I'll check the testsuite status for the *-superux toolchain and
fix any outstanding issues.

that said, I'll be happy to provide another patch that omits the linux
toolchain and fixes any possible SX testsuite issues - as it will be
almost identical to this one, I suppose another in-depth review will not
be necessary. let's just wait for dave's comments about COFF internals
first ...

>   Would you also be willing to act as a maintainer for the 
> SX port in order to keep it working as the binutils sources change in 
> the future ?
it's a shrink-wrapped offer: a maintainer comes with the patch. ;) not
sure about the name yet, but there will be one, of course.

regards,
  jaKa

-- 
email: jaka@xlab.si
w3:    http://www.gmajna.net/svojat/jaka/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]