Re: PATCH: Make STT_GNU_IFUNC symbol dynamic

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Sun, May 24, 2009 at 8:50 AM, Ulrich Drepper <drepper@redhat.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> H.J. Lu wrote:
>> If you can check in your glibc patch, I can test my binutis change
>> before I submit it.
>
> Your patch seems fine. ?You can do testing with it. ?Once I have such a
> binutils version myself and can test it I'll check it in.

Here is the complete binutils patch for i386 and x86-64,  tested wih
the enclosed glibc patch on Linux/ia32 and Linux/Intel64.  I will check
it into binutlls trunk if I don't hear any objections within 12 hours.

BTW, I will post a summary to x86-64 and ia32 psABI mailing list after
my binutils patch is checked in.

Thanks.


-- 
H.J.
---
bfd/

2009-05-24  H.J. Lu  <hongjiu.lu@intel.com>

	* elf32-i386.c (elf_howto_table): Add R_386_IRELATIVE.
	(elf_i386_reloc_type_lookup): Likewise.
	(R_386_tls): Removed.
	(R_386_irelative): New.
	(R_386_vt_offset): Updated.
	(elf_i386_rtype_to_howto): Likewise.
	(elf_i386_finish_dynamic_symbol): Generate R_386_IRELATIVE
	relocation for local STT_GNU_IFUNC symbol.

	* elf64-x86-64.c (x86_64_elf_howto): Add R_X86_64_IRELATIVE.
	(x86_64_reloc_map): Likewise.
	(R_X86_64_standard): Updated.
	(elf64_x86_64_finish_dynamic_symbol): Generate R_X86_64_IRELATIVE
	relocation for local STT_GNU_IFUNC symbol.

	* elflink.c (_bfd_elf_symbol_refs_local_p): Return FALSE on
	STT_GNU_IFUNC symbol.
	(_bfd_elf_link_hash_hide_symbol): Don't clean plt on
	STT_GNU_IFUNC symbol.

	* reloc.c (BFD_RELOC_386_IRELATIVE): New.
	(BFD_RELOC_X86_64_IRELATIVE): Likewise.
	* bfd-in2.h: Regenerated.
	* libbfd.h: Likewise.

include/elf/

2009-05-24  H.J. Lu  <hongjiu.lu@intel.com>

	* i386.h (R_386_IRELATIVE): New.
	* x86-64.h (R_X86_64_IRELATIVE): Likewise.

ld/testsuite/

2009-05-24  H.J. Lu  <hongjiu.lu@intel.com>

	* ld-ifunc/ifunc.exp: Run *.d.

	* ld-ifunc/ifunc-1-x86.d: New.
	* ld-ifunc/ifunc-1-x86.s: Likewise.

Attachment: binutils-ifunc-2.patch
Description: Text document

Attachment: libc-ifunc-3.patch
Description: Text document