This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH-bfd] i386-mingw32-ld crash on x86_64 linux
H.J. Lu wrote:
> On Sun, Apr 19, 2009 at 2:30 PM, Dave Korn
> <dave.korn.cygwin@googlemail.com> wrote:
>> Dave Korn wrote:
>>
>>> Brilliant. I'll run it through a full testsuite and we'll see about getting
>>> it checked in. Thanks for contributing :)
>> Tested on i686-pc-cygwin natively, and cross from i686-pc-linux-gnu to
>> {arm-epoc-pe, arm-wince-pe, i386-pc-netbsdpe, i386-pc-pe, i586-pc-interix,
>> i586-unknown-beospe, i686-pc-cygwin, i686-pc-mingw32, mcore-unknown-pe,
>> powerpcle-unknown-pe, sh-unknown-pe, thumb-epoc-pe, x86_64-pc-freebsd,
>> x86_64-pc-linux-gnu, x86_64-pc-mingw32} without regressions.
>>
>> bfd/ChangeLog
>>
>> 2009-04-19 Peter O'Gorman <binutils@mlists.thewrittenword.com>
>> Alan Modra <amodra@bigpond.net.au>
>> Dave Korn <dave.korn.cygwin@gmail.com>
>>
>> * peXXigen.c (_bfd_XXi_swap_sym_in): Fix name handling w.r.t
>> long names and non-NUL-terminated strings.
>>
>> Ok?
>>
>
> Where is the patch?
Oops. Here is what I tested; it differs from Peter's original only in two
insignificant whitespaces.
cheers,
DaveK
Index: bfd/peXXigen.c
===================================================================
--- bfd/peXXigen.c.orig 2009-04-18 15:32:06.773969268 +0000
+++ bfd/peXXigen.c 2009-04-19 03:17:19.246352672 +0000
@@ -129,6 +129,9 @@
they will be handled somewhat correctly in the bfd code. */
if (in->n_sclass == C_SECTION)
{
+ char namebuf[SYMNMLEN + 1];
+ const char *name = namebuf;
+
in->n_value = 0x0;
/* Create synthetic empty sections as needed. DJ */
@@ -136,33 +139,25 @@
{
asection *sec;
- for (sec = abfd->sections; sec; sec = sec->next)
- {
- if (strcmp (sec->name, in->n_name) == 0)
- {
- in->n_scnum = sec->target_index;
- break;
- }
- }
+ name = _bfd_coff_internal_syment_name (abfd, in, namebuf);
+ sec = bfd_get_section_by_name (abfd, name);
+ if (sec != NULL)
+ in->n_scnum = sec->target_index;
}
if (in->n_scnum == 0)
{
int unused_section_number = 0;
asection *sec;
- char *name;
flagword flags;
-
+ char * namecpy = bfd_alloc (abfd, (bfd_size_type) strlen (name) + 1);
+ strcpy(namecpy, name);
for (sec = abfd->sections; sec; sec = sec->next)
if (unused_section_number <= sec->target_index)
unused_section_number = sec->target_index + 1;
- name = bfd_alloc (abfd, (bfd_size_type) strlen (in->n_name) + 10);
- if (name == NULL)
- return;
- strcpy (name, in->n_name);
flags = SEC_HAS_CONTENTS | SEC_ALLOC | SEC_DATA | SEC_LOAD;
- sec = bfd_make_section_anyway_with_flags (abfd, name, flags);
+ sec = bfd_make_section_anyway_with_flags (abfd, namecpy, flags);
sec->vma = 0;
sec->lma = 0;