This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch]: dump of PE+ x64 pdata section


Kai Tietz wrote:

> ok I'll adjust those stuff. Should I adjust the ce function also,
> becaue here a lot of those straying whitespaces are coming from.

  I don't know if it's terribly important to fix up minor formatting glitches
in old code; generally it suffices to leave it until someone is next editing
the affected area anyway.  (Note that this is not a statement of binutils
policy, I'm not aware if there are specific guidelines about this matter, it's
just IMO).  But since this is a new copy of the function in a new file, we may
as well get this one correct from the start.

> I want to add some testcases, when I completed with the next patch
> which dumps  .xdata, too.

  Great, thank you.  I tested your patch; it all went smoothly, so I don't see
any real problems with it, just these trivial formatting matters.

    cheers,
      DaveK


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]