This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] gold: add incremental input structures definitions


>>>>> "Mikolaj" == Mikolaj Zalewski <mikolajz@google.com> writes:

Mikolaj> diff --git a/elfcpp/elfcpp.h b/elfcpp/elfcpp.h
Mikolaj> +  SHT_GNU_INCREMENTAL_INPUTS = 0x6ffffff5,

Mikolaj> diff --git a/include/elf/common.h b/include/elf/common.h
Mikolaj> +#define SHT_GNU_INCREMENTAL_INPUTS 0x6ffffff4   /* incremental build data */

I don't know but I assume you meant for these values to be the same.

Also, it seems weird to duplicate constants like this at all, for
exactly this reason.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]