This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [Patch - hppa] add compile time check for immediate values of
- From: "John David Anglin" <dave at hiauly1 dot hia dot nrc dot ca>
- To: deller at gmx dot de (Helge Deller)
- Cc: binutils at sourceware dot org, dave dot anglin at nrc dot ca, amodra at bigpond dot net dot au
- Date: Sun, 22 Feb 2009 15:32:10 -0500 (EST)
- Subject: Re: [Patch - hppa] add compile time check for immediate values of
> +/* Store immediate values of shift/deposit/extract functions. */
> +
> +#define SAVE_IMMEDIATE(VALUE) \
> + { \
> + if (immediate_check) \
> + { \
> + if (pos == -1) \
> + pos = VALUE; \
> + else \
> + if (len == -1) \
> + len = VALUE; \
> + } \
> + }
Another minor tweak. Put parentheses around the uses of "VALUE".
It's ok to have "else if" on one line. However, body of the first
if should be indented. The only exception to that rule is case
statements.
The patch is ok with that change.
Dave
--
J. David Anglin dave.anglin@nrc-cnrc.gc.ca
National Research Council of Canada (613) 990-0752 (FAX: 952-6602)