This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch]: Regression in windres
Hello Christoper,
2009/2/7 Christopher Faylor <cgf-use-the-mailinglist-please@sourceware.org>:
> On Fri, Feb 06, 2009 at 07:54:32PM +0100, Kai Tietz wrote:
>>Hello,
>>
>>I noticed a typo in my last change of windres.
>>
>>ChangeLog
>>
>>2009-02-06 Kai Tietz <kai.tietz@onevision.com>
>>
>> * windres.c (set_endianess): Copy name without leading '-'.
>>
>>Is this patch ok for apply?
>
> Looking at this with greater context, couldn't you just achieve the same thing by
> using a "tname = ++hyp" a few lines above this? That avoids having to calculate
> hyp + 1 twice.
>
> cgf
>
> Index: windres.c
> ===================================================================
> RCS file: /cvs/src/src/binutils/windres.c,v
> retrieving revision 1.37
> diff -d -u -r1.37 windres.c
> --- windres.c 6 Jan 2009 15:36:05 -0000 1.37
> +++ windres.c 6 Feb 2009 23:08:58 -0000
> @@ -1102,7 +1102,7 @@
>
> if (hyp != NULL)
> {
> - tname = hyp + 1;
> + tname = ++hyp;
>
> /* Make sure we dectect architecture names
> for triplets like "pe-arm-wince-little". */
>
>
Ok, this works, too. Do you commit it, or should I do?
Cheers,
Kai
--
| (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination