This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Add new INSN_* into mips.h
- From: Eric Christopher <echristo at apple dot com>
- To: Nick Clifton <nickc at redhat dot com>
- Cc: Eric Fisher <joefoxreal at gmail dot com>, binutils at sourceware dot org
- Date: Tue, 6 Jan 2009 08:37:59 -0800
- Subject: Re: Add new INSN_* into mips.h
- References: <d6afecde0812242224s3f7b6d11rdd5417a2268084d5@mail.gmail.com> <d6afecde0812292200n2dede51bt8c9d910ce6fde2c1@mail.gmail.com> <496379E5.9040701@redhat.com>
On Jan 6, 2009, at 7:33 AM, Nick Clifton wrote:
Hi Eric.
I was hoping that a MIPS person would answer this, but ...
Sorry, I missed it. :(
I have two solutions for this problem. One is to add a new field
"membership2" into struct mips_opcode, just like what "pinfo2" does.
Another way is to change the "membership" field from bit collection
to
a function address. So mips_builtin_opcodes will look like this,
Personally I would go with whichever method is the least intrusive,
and hence the least likely to generate new bugs. To me this sounds
like your first suggestion - the second membership mask.
Agreed.
-eric