This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch]: Make sure that $ characters are prefixed by backslash

From: Andreas Schwab <schwab at suse dot de>
To: Michael Hennebry <hennebry at web dot cs dot ndsu dot nodak dot edu>
Cc: Dave Korn <dave dot korn dot cygwin at googlemail dot com>, Kai Tietz <ktietz70 at googlemail dot com>, binutils <binutils at sourceware dot org>
Date: Mon, 05 Jan 2009 09:12:28 +0100
Subject: Re: [patch]: Make sure that $ characters are prefixed by backslash
References: <90baa01f0901040457k509348c9s109d9e620b3ae046@mail.gmail.com> <jesknzdxg4.fsf@sykes.suse.de> <90baa01f0901040523q7fd99be5jb2fefc3524902f82@mail.gmail.com> <2ca21dcc0901041518i249571ffv7a4a89cd935aaef1@mail.gmail.com> <alpine.DEB.1.00.0901041739150.30582@mail.cs.ndsu.nodak.edu>

Michael Hennebry <hennebry@web.cs.ndsu.nodak.edu> writes:

> On Sun, 4 Jan 2009, Dave Korn wrote:
>
>> Kai Tietz wrote:
>>>
>>> Thanks for catching this.
>>> Updated patch ok for apply?
>>
>>  Also, I think you don't need to escape the ones inside single-quotes:
>>
>> @@ -1636,7 +1636,7 @@ gld_${EMULATION_NAME}_place_orphan (asec
>>
>>   /* Look through the script to see where to place this section.  */
>>   if (!link_info.relocatable
>> -      && (dollar = strchr (secname, '$')) != NULL)
>> +      && (dollar = strchr (secname, '\$')) != NULL)
>
> I'm pretty sure that, in C, a dollar sign may not be escaped by a slash.

This is part of a big (unquoted) sh here document.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Follow-Ups:
- Re: [patch]: Make sure that $ characters are prefixed by backslash
  - From: Alan Modra

References:
- [patch]: Make sure that $ characters are prefixed by backslash
  - From: Kai Tietz
- Re: [patch]: Make sure that $ characters are prefixed by backslash
  - From: Andreas Schwab
- Re: [patch]: Make sure that $ characters are prefixed by backslash
  - From: Kai Tietz
- Re: [patch]: Make sure that $ characters are prefixed by backslash
  - From: Dave Korn
- Re: [patch]: Make sure that $ characters are prefixed by backslash
  - From: Michael Hennebry

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]