This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add support for Lattice Mico32 (LM32)


Hi Jon,

The following patch adds support for the Lattice Mico32 CPU. Mico32 is an
Open Source 32-bit embedded CPU developed by Lattice Semi. I'm happy to be
listed as the maintainer of this port.

Thanks very much for submitting this port. I have applied it to the sources, although I did make a few changes:


* There was a compile time warning/error:

.../opcodes/lm32-asm.c: In function 'parse_imm':
.../opcodes/lm32-asm.c:74: error: pointer targets in passing argument 4 of 'cgen_parse_signed_integer' differ in signedness


Changing 'value' (declared at line 72) to a signed long fixes this problem.

* We are no longer using the PARAMS macro, so I fixed the places where it was being used.

* The copyright notices in the new files did not actually assign the copyright to the FSF and they were using version 2 of the GPL, whereas we are now using version 3.

* The dependencies for the generated files in the opcodes directory were set to point to the wrong place (cgen/cpu instead of cpu/).

* You directly edited the bfd-in2.h header file, which is an auto-generated file. You needed to add the LM32 relocations to the bfd/reloc.c file and then regenerate bfd-in2.h.

* There were a few minor formatting issues (whitespace, comments, function prototypes).


Apart from those points everything else was fine. The patch applied cleanly and did not introduce any new failures, so welcome to the binutils team!


Cheers
  Nick


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]