This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Committed: elf32-cris.c randomly spotted missing h != NULL test.


Just a random spotting.  No test-case and it doesn't seem
worthwhile to try and construct one.  As always,
regression-tested cross to cris-axis-elf.

bfd:
	* elf32-cris.c (cris_elf_relocate_section) <R_CRIS_8, R_CRIS_16>
	<R_CRIS_32>: Add missing gate h != NULL for h->def_regular test.

Index: elf32-cris.c
===================================================================
RCS file: /cvs/src/src/bfd/elf32-cris.c,v
retrieving revision 1.92
diff -p -u -r1.92 elf32-cris.c
--- elf32-cris.c	17 Dec 2008 02:14:30 -0000	1.92
+++ elf32-cris.c	17 Dec 2008 02:27:38 -0000
@@ -1494,7 +1494,7 @@ cris_elf_relocate_section (output_bfd, i
 		   && r_type != R_CRIS_16_PCREL
 		   && r_type != R_CRIS_32_PCREL)
 		  || (!info->symbolic
-		      || !h->def_regular)))
+		      || (h != NULL && !h->def_regular))))
 	    {
 	      Elf_Internal_Rela outrel;
 	      bfd_byte *loc;

brgds, H-P


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]