This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

2.19 -enable-targets=all one error in m68k-dis.c due to longjmp, easily fixed with volatile


/src/binutils-2.19/configure -enable-targets=all -v -disable-nls -with-sysroot
make
=>
/src/binutils-2.19/opcodes/m68k-dis.c: In function 'print_insn_m68k':
/src/binutils-2.19/opcodes/m68k-dis.c:1474: warning: argument 'info' might be cl
obbered by 'longjmp' or 'vfork'
make[4]: *** [m68k-dis.lo] Error 1

fix:
 
jay@ia64a:/obj/all$ diff -u /src/binutils-2.19/opcodes/m68k-dis.c.orig /src/binu
tils-2.19/opcodes/m68k-dis.c
--- /src/binutils-2.19/opcodes/m68k-dis.c.orig  2008-11-22 10:53:57.000000000 -0
800
+++ /src/binutils-2.19/opcodes/m68k-dis.c       2008-11-22 10:54:59.000000000 -0
800
@@ -1471,8 +1471,10 @@
    on INFO->STREAM.  Returns length of the instruction, in bytes.  */
 int
-print_insn_m68k (bfd_vma memaddr, disassemble_info *info)
+print_insn_m68k (bfd_vma memaddr, disassemble_info *xinfo)
 {
+/* volatile so it survives longjmp */
+  disassemble_info * volatile info = xinfo;
   unsigned int arch_mask;
   struct private priv;
   int val;
 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]