This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Scale DW_CFA_advance_loc[124] output values
- From: "John David Anglin" <dave at hiauly1 dot hia dot nrc dot ca>
- To: jakub at redhat dot com
- Cc: schwab at suse dot de, binutils at sourceware dot org
- Date: Tue, 18 Nov 2008 11:25:15 -0500 (EST)
- Subject: Re: [PATCH] Scale DW_CFA_advance_loc[124] output values
> Yeah, seems ehopt.c is broken in many places too, at least in
> check_eh_frame, eh_frame_estimate_size_before_relax and
> eh_frame_convert_frag. Fortunately gcc was always using code
> alignment factor 1, so it didn't matter.
I'm thinking the optimization in check_eh_frame is only valid when
the code alignment factor is 1. That's the only time the advance
can be represented as a difference of symbols.
The standard is clear that the new location is computed by adding
check_eh_frame in all four cases.
Dave
--
J. David Anglin dave.anglin@nrc-cnrc.gc.ca
National Research Council of Canada (613) 990-0752 (FAX: 952-6602)