This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Scale DW_CFA_advance_loc[124] output values
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: John David Anglin <dave at hiauly1 dot hia dot nrc dot ca>, binutils at sourceware dot org
- Date: Tue, 18 Nov 2008 16:58:36 +0100
- Subject: Re: [PATCH] Scale DW_CFA_advance_loc[124] output values
- References: <20081118145312.D4D164DF8@hiauly1.hia.nrc.ca> <jebpwd2h4a.fsf@sykes.suse.de>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Tue, Nov 18, 2008 at 04:23:01PM +0100, Andreas Schwab wrote:
> "John David Anglin" <dave@hiauly1.hia.nrc.ca> writes:
>
> > The enclosed patch fixes GCC PR target/37610. This was noticed
> > on hppa-unknown-linux-gnu because DWARF2_LINE_MIN_INSN_LENGTH is
> > defined to 4 in tc-hppa.h. This resulted incorrect advances being
> > computed in the unwind process, resulting in the failure of the
> > g++.dg/eh/pr29166.C execution test.
> >
> > A fix to GCC is also needed to detect buggy assembler versions.
> >
> > Tested on hppa-unknown-linux-gnu. Ok?
>
> What about the uses in ehopt.c?
Yeah, seems ehopt.c is broken in many places too, at least in
check_eh_frame, eh_frame_estimate_size_before_relax and
eh_frame_convert_frag. Fortunately gcc was always using code
alignment factor 1, so it didn't matter.
Jakub