This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: fix strip & objcopy bug with foreign linker
- From: Nick Clifton <nickc at redhat dot com>
- To: Nathan Sidwell <nathan at codesourcery dot com>
- Cc: binutils <binutils at sources dot redhat dot com>
- Date: Fri, 14 Nov 2008 14:46:41 +0000
- Subject: Re: fix strip & objcopy bug with foreign linker
- References: <4919BF5E.4030408@codesourcery.com>
Hi Nathan,
> 2008-11-11 Nathan Sidwell <nathan@codesourcery.com>
>
> bfd/
> * elf.c (assign_file_positions_for_load_sections): Use
> header_size
> to avoid moving the load address of file headers.
> (assign_file_positions_for_load_sections): Set header_size for
> segments containing the file header.
>
> include/elf/
> * internal.h (struct elf_segment_map): Add header_size field.
Approved and applied. Note I made one change:
+ if (header_pad < off)
changed to
+ if (header_pad < (bfd_vma) off)
to avoid compile time warnings about a comparison between a signed and
an unsigned quantity. (For some targets the file_ptr type is signed).
Cheers
Nick