Re: [PATCH] Add DT_CONFIG support to ld

[Nick Clifton <nickc at redhat dot com>]

Hi Clayton,

> I've attached a patch that adds DT_CONFIG support to ld, via a -C and
> --config command-line options.  We use this on Solaris to specify a
> different path to the linker configuration other than the default for
> binaries we generate in house.

Thank you very much for submitting this patch.  There are a few issues 
with it however, but if we can resolve these then I would be happy to 
accept the patch

  1.  Does your employer have an FSF copyright assignment in place
      for binutils work ?  (I am assuming that you wrote the patch
      on behalf of your employer).  If so, please could you send me
      a copy of the response from the FSF.  If not, please could
      you ask your employer to obtain one as we cannot accept the
      patch without it.

  2.  Your patch needs a couple of ChangeLog entries to go with it,
      one for the bfd/ directory and one for the ld/ directory.

  3.  You include a change to the bfd/bfd-in2.h file, which is an
      automatically generated file.  You ought to make the change
      to the bfd-in.h file instead and then just mention in the
      ChangeLog entry that bfd-in2.h is regenerated.

  4.  You call the long version of the new command line option
      -config but I think that it would be better to call it
      --dt-config.  This makes it clearer (to me anyway) that it
      is an option for setting the DT_CONFIG attribute in a binary
      rather than, say, an option for configuring the linker.

  5.  You need to include a patch to ld/ld.texinfo documenting the
      new command line option and an entry in ld/NEWS mentioning it.

  6.  It would be nice if you could include a new testcase in the
      linker testsuite that checks this new functionality.

Cheers
  Nick