This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RFA: fixlet in elfxx-mips.c
- From: Tom Tromey <tromey at redhat dot com>
- To: binutils <binutils at sourceware dot org>
- Date: Mon, 08 Sep 2008 17:19:26 -0600
- Subject: RFA: fixlet in elfxx-mips.c
- Reply-to: Tom Tromey <tromey at redhat dot com>
I'm using x86 F8. The gcc on this system is based on 4.1.2.
When I build gdb with --enable-targets=all, the build fails in bfd.
On this platform, the 'sec' parameter to mips16_stub_symndx is unused
(due to how the macros expand on this host). Since the build is done
with -Werror, this causes a failure.
This patch fixes the problem by marking the argument unused.
Ok?
Tom
ChangeLog:
2008-09-08 Tom Tromey <tromey@redhat.com>
* elfxx-mips.c (mips16_stub_symndx) <sec>: Mark argument as
unused.
Index: elfxx-mips.c
===================================================================
RCS file: /cvs/src/src/bfd/elfxx-mips.c,v
retrieving revision 1.249
diff -u -r1.249 elfxx-mips.c
--- elfxx-mips.c 18 Aug 2008 18:14:04 -0000 1.249
+++ elfxx-mips.c 8 Sep 2008 23:16:17 -0000
@@ -1409,7 +1409,8 @@
function, or 0 if we can't decide which function that is. */
static unsigned long
-mips16_stub_symndx (asection *sec, const Elf_Internal_Rela *relocs,
+mips16_stub_symndx (asection *sec ATTRIBUTE_UNUSED,
+ const Elf_Internal_Rela *relocs,
const Elf_Internal_Rela *relend)
{
const Elf_Internal_Rela *rel;