This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH] Add missing trailing newline to PE warning message.
- From: Peter Rosin <peda at lysator dot liu dot se>
- To: binutils at sourceware dot org
- Date: Mon, 08 Sep 2008 15:11:27 +0200
- Subject: [PATCH] Add missing trailing newline to PE warning message.
Hi!
This is only a buglet, but I have failed to get myself to ignore it, so
here I go...
During linking on Cygwin, I get messages like this:
/usr/lib/gcc/i686-pc-cygwin/3.4.4/../../../../i686-pc-cygwin/bin/ld:
warning: auto-importing has been activated without --enable-auto-import
specified on the command line.
This should work unless it involves constant data structures referencing
symbols from auto-imported DLLs.Info: resolving _foo by linking to
__imp__foo (auto-import)
Info: resolving _bar by linking to __imp__bar (auto-import)
Info: resolving _baz by linking to __imp__baz (auto-import)
I want a newline between "DLLs." and "Info:", so I prepared the
attached patch for ld.
Cheers,
Peter
2008-09-08 Peter Rosin <peda@lysator.liu.se> (tiny change)
* emultempl/pe.em (pe_find_data_imports): Add trailing newline
to warning message.
* emultempl/pep.em (pep_find_data_imports): Likewise.
Index: src/ld/emultempl/pe.em
===================================================================
RCS file: /cvs/src/src/ld/emultempl/pe.em,v
retrieving revision 1.133
diff -u -r1.133 pe.em
--- src/ld/emultempl/pe.em 17 Aug 2008 03:12:50 -0000 1.133
+++ src/ld/emultempl/pe.em 8 Sep 2008 13:04:47 -0000
@@ -936,7 +936,7 @@
{
warned = TRUE;
einfo (_("%P: warning: auto-importing has been activated without --enable-auto-import specified on the command line.\n\
-This should work unless it involves constant data structures referencing symbols from auto-imported DLLs."));
+This should work unless it involves constant data structures referencing symbols from auto-imported DLLs.\n"));
}
}
Index: src/ld/emultempl/pep.em
===================================================================
RCS file: /cvs/src/src/ld/emultempl/pep.em,v
retrieving revision 1.12
diff -u -r1.12 pep.em
--- src/ld/emultempl/pep.em 17 Aug 2008 03:12:50 -0000 1.12
+++ src/ld/emultempl/pep.em 8 Sep 2008 13:04:48 -0000
@@ -895,7 +895,7 @@
{
warned = TRUE;
einfo (_("%P: warning: auto-importing has been activated without --enable-auto-import specified on the command line.\n\
-This should work unless it involves constant data structures referencing symbols from auto-imported DLLs."));
+This should work unless it involves constant data structures referencing symbols from auto-imported DLLs.\n"));
}
}