This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: DWARF2 abstract origin issue
- From: Daniel Jacobowitz <drow at false dot org>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Dmitry Smirnov <divis1969 at gmail dot com>, binutils at sourceware dot org
- Date: Fri, 5 Sep 2008 13:24:25 -0400
- Subject: Re: DWARF2 abstract origin issue
- References: <dd5065570807290816k4a3b3502h44df1551dcf76948@mail.gmail.com> <6dc9ffc80807290838i46496a89obe4b2b998426d814@mail.gmail.com>
On Tue, Jul 29, 2008 at 08:38:36AM -0700, H.J. Lu wrote:
> Is this the same as
>
> http://www.sourceware.org/bugzilla/show_bug.cgi?id=3191
>
> I am enclosing my patch here.
Sorry no one had looked at this.
> 2006-09-29 H.J. Lu <hongjiu.lu@intel.com>
>
> PR ld/3191
> * dwarf2.c (find_abstract_instance_name): Pass a pointer to
> attribute instead of offset. For DW_FORM_ref_addr, get the
> entry at the offset from the .debug_info section.
> (scan_unit_for_symbols): Updated.
This part looks fine, but I suggest you remove the FIXME.
> (_bfd_dwarf2_find_nearest_line): Adjust debug_info
> section vma when needed.
This part looks troublesome though:
> + BFD_ASSERT (msec->vma == 0
> + && msec->alignment_power == 0);
This assertion will not be valid on PE-COFF targets where dwarf
sections have a non-zero VMA.
I'll try to come up with an alternate approach.
--
Daniel Jacobowitz
CodeSourcery