This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: big endian i86

From: Nathan Sidwell <nathan at codesourcery dot com>
To: Nick Clifton <nickc at redhat dot com>
Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, binutils <binutils at sources dot redhat dot com>
Date: Sun, 01 Jun 2008 13:30:10 +0100
Subject: Re: big endian i86
References: <4822F8B6.40405@codesourcery.com> <20080508133205.GA16350@lucon.org> <4829ABF6.8040304@codesourcery.com> <4836BF72.80004@codesourcery.com> <484023E3.9080004@redhat.com>

Nick,

  /* Ignore generic big and little endian elf vectors.  */
  if (   strcmp (target->name, "elf32-big") == 0
      || strcmp (target->name, "elf64-big") == 0
      || strcmp (target->name, "elf32-little") == 0
      || strcmp (target->name, "elf64-little") == 0)
    return 0;
I would also suggest that you turn this issue into a PR and then include the PR number in the comment. That way if we have cause to revisit this code in the future we will have a PR to look up to see why the change was made.

you appear to have checked this patch in as part of your 1.286 commit, but w/o changelog entry. I guess that was accidental -- I don't mind :)

I'm curious about the PR idea -- for GCC we specifically don't mention pr numbers in comments, the comments should stand on their own.

nathan
--
Nathan Sidwell    ::   http://www.codesourcery.com   ::         CodeSourcery

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]