This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: relocs_compatible hook considered harmful
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: binutils at sourceware dot org
- Date: Thu, 24 Apr 2008 10:09:25 +0930
- Subject: Re: relocs_compatible hook considered harmful
- References: <20080423153949.GA29795@caradoc.them.org>
On Wed, Apr 23, 2008 at 11:39:49AM -0400, Daniel Jacobowitz wrote:
> Alan's patch for PR 2434 introduced a guard on the call to
> check_relocs. Any time this returns false, check_relocs will not be
> called. But relocate_section gets called anyway.
Err, I think you have the wrong patch. The PR2423 fix didn't make
functional changes in this area. The most recent functional change in
the way check_relocs was called, prior to relocs_compatible, was
http://sourceware.org/ml/binutils/2003-12/msg00001.html.
Also, _bfd_elf_default_relocs_compatible does exactly as prior to
relocs_compatible, so I'm a little mystified by your subject line.
--
Alan Modra
Australia Development Lab, IBM