This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

More large section cleanup


And another couple of patches for the large section code, found by
testing on an x86_64 system.  This fixes some problems with the
exception frame support.

Ian


2008-04-19  Ian Lance Taylor  <iant@google.com>

	* object.cc (Sized_relobj::do_add_symbols): Always pass
	local_symbol_count_ to add_from_relobj.

	* testsuite/Makefile.am (many_sections_r_test): New target.
	(many_sections_r_test_SOURCES): Remove.
	(many_sections_r_test_DEPENDENCIES): Remove.
	(many_sections_r_test_LDFLAGS): Remove.
	(many_sections_r_test_LDADD): Remove.


Index: object.cc
===================================================================
RCS file: /cvs/src/src/gold/object.cc,v
retrieving revision 1.69
diff -u -p -r1.69 object.cc
--- object.cc	19 Apr 2008 18:30:58 -0000	1.69
+++ object.cc	19 Apr 2008 19:34:30 -0000
@@ -946,10 +946,7 @@ Sized_relobj<size, big_endian>::do_add_s
     reinterpret_cast<const char*>(sd->symbol_names->data());
   symtab->add_from_relobj(this,
 			  sd->symbols->data() + sd->external_symbols_offset,
-			  symcount,
-			  (sd->external_symbols_offset == 0
-			   ? this->local_symbol_count_
-			   : 0),
+			  symcount, this->local_symbol_count_,
 			  sym_names, sd->symbol_names_size,
 			  &this->symbols_);
 
Index: testsuite/Makefile.am
===================================================================
RCS file: /cvs/src/src/gold/testsuite/Makefile.am,v
retrieving revision 1.66
diff -u -r1.66 Makefile.am
--- testsuite/Makefile.am	19 Apr 2008 19:15:35 -0000	1.66
+++ testsuite/Makefile.am	19 Apr 2008 19:39:08 -0000
@@ -570,12 +570,10 @@
 	mv -f $@.tmp $@
 
 check_PROGRAMS += many_sections_r_test
-many_sections_r_test_SOURCES =
-many_sections_r_test_DEPENDENCIES = gcctestdir/ld many_sections_r_test.o
-many_sections_r_test_LDFLAGS = -Bgcctestdir/
-many_sections_r_test_LDADD = many_sections_r_test.o
 many_sections_r_test.o: many_sections_test.o gcctestdir/ld
 	gcctestdir/ld -r -o $@ many_sections_test.o
+many_sections_r_test: many_sections_r_test.o gcctestdir/ld
+	$(CXXLINK) -Bgcctestdir/ many_sections_r_test.o $(LIBS)
 
 if CONSTRUCTOR_PRIORITY
 

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]